-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add -done class names #269
Conversation
Trivial question, but |
Done is more in keeping with the existing verbage of the CSSTransition, e.g. enter enter-active enter-done, vs enter, enter-active, entered we may want to change it tho to match Transition at somepoint |
Hey, just wanted to check if there's something you think needs to be changed to merge these changes. Have you decided on 'done' vs 'entered' for instance? |
looks good can you update the doc comments to explain the new classes? thanks |
thanks! |
@jquense When is this getting released? I'm currently getting bitten by this. We can only use class names because we're using |
Anyone knows a workaround to set a base className when there's no transition in progress, until this is released? Only way I found is to use a wrapper element just for the transition. |
@RanzQ I use a default class to start with. I then set my own done classname using onEntered and onExited webhooks.
|
Is there any news on when this is going to be released? |
New "Done" states as discussed here.
Before this change there was no way to persist the styles that have been transitioned to, without fiddling with the callbacks. Now users can define
#{transition-name}-done
classes or custom ones to denote the transition as being done and keep the element in the new state or set other styles for it.Here's a small Sass mixin that generates css compliant with this change.